feat: adapted component ManageTokensModal to be able to treat both IC and Ethereum tokens #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Ethereum tokens
AntonioVentilii-DFINITY
force-pushed
the
feature/chain-fusion/adapt-manage-tokens-to-accepts-erc20
branch
from
c60224b
to
4963b4c
Compare
src/frontend/src/icp-eth/components/tokens/ManageTokensModal.svelte
Outdated
Show resolved
Hide resolved
AntonioVentilii-DFINITY
deleted the
feature/chain-fusion/adapt-manage-tokens-to-accepts-erc20
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We now proceed to merge the flow of adding Erc20 tokens into the general modal
ManageTokensModal.Changes
IcAddTokenFormwith componentAddTokenByNetworkto have the network choice (default to current network, if defined).AddTokenReview.Tests
On local replica, adding tokens wroked as expected.