feat: included AddTokenReview in component ManageTokensModal #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,6 +100,69 @@ | |||
| } | |||
| }; | |||
|
|
|||
| let erc20Metadata: Erc20Metadata | undefined; | |||
|
|
|||
| const saveErc20Token = async () => { | |||
There was a problem hiding this comment.
If we are already there, I would rather like to have this in a service or at least everything we can extract. Or are you planing to refactor that afterwards?
There was a problem hiding this comment.
i was planning to do it afterwrds actually, so that we can move step by step, it seems the best way to have smaller PRs
what do you think? I refactor first?
|
You are right, better refactor first... closing this |
AntonioVentilii-DFINITY
deleted the
feature/chain-fusion/include-ethereum-add-token-flow-in-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We add the component
AddTokenReview(specific to Ethereum network) in the generic modalManageTokensModal.Changes
savefrom Ethereum componentAddTokenModaland pasted it inManageTokensModal.erc20Metadataanderc20ContractAddressto pass toAddTokenReview.AddTokenReviewand created conditional rendering based on network.