feat: created new component AddTokenByNetwork #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii-DFINITY
force-pushed
the
feature/chain-fusion/new-component-add-token-by-network
branch
from
5c3c6fb
to
29272a2
Compare
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
|
In addition to the comment, noticed that the spacing is a bit off but it might be related to the 
|
AntonioVentilii-DFINITY
force-pushed
the
feature/chain-fusion/new-component-add-token-by-network
branch
from
4bf7c38
to
7f8a31b
Compare
AntonioVentilii-DFINITY
force-pushed
the
feature/chain-fusion/new-component-add-token-by-network
branch
from
1b107e0
to
689ebc6
Compare
AntonioVentilii-DFINITY
force-pushed
the
feature/chain-fusion/new-component-add-token-by-network
branch
from
e333f97
to
a169481
Compare
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
peterpeterparker
approved these changes
Jun 20, 2024
src/frontend/src/icp-eth/components/tokens/AddTokenByNetwork.svelte
Outdated
Show resolved
Hide resolved
AntonioVentilii-DFINITY
deleted the
feature/chain-fusion/new-component-add-token-by-network
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This new component allows the user to select the network to add a specific token (for now either IC or Ethereum).
It uses the already existing components
IcAddTokenFormandAddTokenForm.Preview: