Skip to content

Commit

Permalink
Fix path to candid description in release (#767)
Browse files Browse the repository at this point in the history
We added the candid description as a released asset, however there were
two issues:

* The (relative) path to the `.did` was incorrect,
* The release script didn't support files outside of the top-level
  directory.
  • Loading branch information
nmattia authored Jul 25, 2022
1 parent 63553cc commit 6af46b8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/canister-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ jobs:
internet_identity_production.wasm \
internet_identity_dev.wasm \
internet_identity_test.wasm \
internet_identity.did
src/internet_identity/internet_identity.did
env:
# populated by GitHub Actions
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow
Expand Down
8 changes: 4 additions & 4 deletions scripts/release
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,12 @@ function do_release() {
echo "uploading assets"
for filename in "${filenames[@]}"
do
filepath="$filename"
filename=$(basename "$filename")
echo -n " - $filename"
echo "$release_json" | jq
echo -n " - $filename ($filepath)"
local upload_url; upload_url=$(echo "$release_json" | jq -cMr '.upload_url' | sed "s/{.*}/?name=$filename/")
echo "upload url: $upload_url"
gh_post_tgz "$upload_url" "$filename" >/dev/null
echo -n "upload url: $upload_url"
gh_post_tgz "$upload_url" "$filepath" >/dev/null
echo " (done)"
done
fi
Expand Down

0 comments on commit 6af46b8

Please sign in to comment.