build: esm #31
Draft
build: esm #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the CLI installed globally locally from npm, we are facing following issue:
@lmuntaner narrowed the issue to
listenTimeoutIdwhich is indeed used before its declaration in the ledger-hq Transport feature.While moving from CJS to ESM might not solve the issue, we found this issue evanw/esbuild#542 (comment) in esbuild where the creator of the library recommend to move to ESM to maybe solve the issue. So we thought it's worth giving a shot.
That said, when I look at the generated code, it still seems that the
var listenTimeoutIdis declared after it's usage, so not sure ultimately if it will really works out.