test(e2e): test tip of the branch #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Aug 3, 2023
Co-authored-by: Eric Swanson <[email protected]>
ericswanson-dfinity
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we install extensions in e2e tests. This will allow us to test the latest changes in the codebase and catch any issues early on.
Instead of running tests against the extension installed from the latest release (by installing tarball from GitHub Releases via
dfx extension install), we will run tests against extensions built from the source code of the tip of the branch.We're building the extension from the source code using cargo-dist (the same thing that we're using in release CI) and installing it manually (without using
dfx extensions install ..., and instead moving the directory with extension to$(dfx cache show)/extension; note: perhaps in the future, it will be a good idea to be able to install the extension directly from archive e.g.,dfx extension install --from-archive <URL|PATH>, this will let us get rid ofdfx_extension_install_manually()ine2e/utils.sh).