Add download btns #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owing the inputs to settle before rendering - fixing loop issue
Merge branch 'main' into add-download-btns # Conflicts: # R/lait_modules/mod_app_inputs.R
…odal btn to gov secondary
…djusted text in btn slightly
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JT-39
force-pushed
the
add-download-btns
branch
from
b4360f9
to
245f423
Compare
JT-39
force-pushed
the
add-download-btns
branch
from
245f423
to
9f083c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Adding download functionality to the rest of the app pages.
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app())styler::style_dir()andlintr::lint_dir())What is the current behaviour?
There is only download functionality for two pages (LA and All LA).
What is the new behaviour?
Download functionality added for the regional and statistical neighbours pages. This spans across tables and charts. A number of different methods of downloading buttons were trialled for the charts - including modals and copy to clipboard.
The most likely form will take the form of buttons on the same card as the plots. One a button to open a modal (pop-up) for the SVG and HTML downloads, with another button underneath this to copy the chart to the clipboard.
Anything else
The bar charts on the statistical neighbour page still need the download functionality to be added but first we should agree on the form.