Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EES-5541 - Boundary level per dataset form changes #5308

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

bennettstuart
Copy link
Collaborator

@bennettstuart bennettstuart commented Oct 4, 2024

Overview

Most changes are hidden behind a feature flag.

This work introduces the concept of boundaryLevels on dataSetConfigs on maps, this is to allow maps to show different geoJson per dataset as to produce a more accurate representation of data alongside their boundaries on the map.

  • Reducer actions altered to cater for dataset boundary levels
  • Separated Chart boundary levels form data setup and boundary levels form into their own components for simplicity.
  • (hidden for now) data set table with boundary level select, below existing boundary level select, to allow users to select boundary levels per data set9

Additional

  • Added onChange prop to Form component
    • <Effect value={formValues} onChange={props.onChange} /> no longer required (and doesn't work with form array field)
  • Fixed a bug on Chart data groupings tab not allowing modal to close

image

@bennettstuart bennettstuart force-pushed the EES-5402--EES-5541-form-amends branch 2 times, most recently from a6803f3 to 39ac02c Compare October 15, 2024 08:42
@bennettstuart bennettstuart force-pushed the EES-5402--EES-5541-form-amends branch 2 times, most recently from ef99d0f to 1b744fc Compare October 15, 2024 09:10
@bennettstuart bennettstuart marked this pull request as ready for review October 16, 2024 12:10
@bennettstuart bennettstuart changed the base branch from EES-5402 to dev October 16, 2024 12:45
@bennettstuart bennettstuart changed the title EES-5402⬅️EES-5541 - Boundary level per dataset form changes EES-5541 - Boundary level per dataset form changes Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant