-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EES-5541 - Boundary level per dataset form changes #5308
Open
bennettstuart
wants to merge
11
commits into
dev
Choose a base branch
from
EES-5402--EES-5541-form-amends
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennettstuart
force-pushed
the
EES-5402--EES-5541-form-amends
branch
2 times, most recently
from
October 15, 2024 08:42
a6803f3
to
39ac02c
Compare
bennettstuart
force-pushed
the
EES-5402
branch
from
October 15, 2024 08:43
375fa02
to
da49df4
Compare
bennettstuart
force-pushed
the
EES-5402--EES-5541-form-amends
branch
2 times, most recently
from
October 15, 2024 09:10
ef99d0f
to
1b744fc
Compare
…data set boundary form interaction and select
bennettstuart
force-pushed
the
EES-5402
branch
from
October 16, 2024 12:45
da49df4
to
d627a3e
Compare
bennettstuart
force-pushed
the
EES-5402--EES-5541-form-amends
branch
from
October 16, 2024 12:45
6fead8c
to
f1fb1ba
Compare
bennettstuart
changed the title
EES-5402⬅️EES-5541 - Boundary level per dataset form changes
EES-5541 - Boundary level per dataset form changes
Oct 16, 2024
bennettstuart
force-pushed
the
EES-5402--EES-5541-form-amends
branch
from
October 16, 2024 13:36
c17d345
to
13bcc41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Most changes are hidden behind a feature flag.
This work introduces the concept of boundaryLevels on dataSetConfigs on maps, this is to allow maps to show different geoJson per dataset as to produce a more accurate representation of data alongside their boundaries on the map.
Additional
<Effect value={formValues} onChange={props.onChange} />
no longer required (and doesn't work with form array field)