-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
EES-5492 - broke orchestrations into their own simplified files and m…
…ade static, to avoid issues whereby exceptions thrown during the construction of Function classes caused the ImportMetadata stage to lock up
- Loading branch information
1 parent
0a93f98
commit b7e1058
Showing
20 changed files
with
447 additions
and
406 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105 changes: 105 additions & 0 deletions
105
...rocessor.Tests/Functions/ProcessCompletionOfNextDataSetVersionImportOrchestrationTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| using GovUk.Education.ExploreEducationStatistics.Public.Data.Processor.Functions; | ||
| using GovUk.Education.ExploreEducationStatistics.Public.Data.Processor.Model; | ||
| using GovUk.Education.ExploreEducationStatistics.Public.Data.Processor.Tests.Extensions; | ||
| using Microsoft.DurableTask; | ||
| using Microsoft.DurableTask.Entities; | ||
| using Microsoft.Extensions.Logging.Abstractions; | ||
| using Moq; | ||
| using static GovUk.Education.ExploreEducationStatistics.Common.Tests.Utils.MockUtils; | ||
|
|
||
| namespace GovUk.Education.ExploreEducationStatistics.Public.Data.Processor.Tests.Functions; | ||
|
|
||
| public abstract class ProcessCompletionOfNextDataSetVersionImportOrchestrationTests | ||
| { | ||
| public class ProcessCompletionOfNextDataSetVersionImportTests | ||
| { | ||
| [Fact] | ||
| public async Task Success() | ||
| { | ||
| var mockOrchestrationContext = DefaultMockOrchestrationContext(); | ||
| var activitySequence = new MockSequence(); | ||
|
|
||
| // Expect an entity lock to be acquired for calling the ImportMetadata activity | ||
| var mockEntityFeature = new Mock<TaskOrchestrationEntityFeature>(MockBehavior.Strict); | ||
| mockEntityFeature.SetupLockForActivity(ActivityNames.ImportMetadata); | ||
| mockOrchestrationContext.SetupGet(context => context.Entities) | ||
| .Returns(mockEntityFeature.Object); | ||
|
|
||
| string[] expectedActivitySequence = | ||
| [ | ||
| ActivityNames.UpdateFileStoragePath, | ||
| ActivityNames.ImportMetadata, | ||
| ActivityNames.CreateChanges, | ||
| ActivityNames.ImportData, | ||
| ActivityNames.WriteDataFiles, | ||
| ActivityNames.CompleteNextDataSetVersionImportProcessing | ||
| ]; | ||
|
|
||
| foreach (var activityName in expectedActivitySequence) | ||
| { | ||
| mockOrchestrationContext | ||
| .InSequence(activitySequence) | ||
| .Setup(context => context.CallActivityAsync(activityName, | ||
| mockOrchestrationContext.Object.InstanceId, | ||
| null)) | ||
| .Returns(Task.CompletedTask); | ||
| } | ||
|
|
||
| await ProcessCompletionOfNextDataSetVersionImport(mockOrchestrationContext.Object); | ||
|
|
||
| VerifyAllMocks(mockOrchestrationContext, mockEntityFeature); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task ActivityFunctionThrowsException_CallsHandleFailureActivity() | ||
| { | ||
| var mockOrchestrationContext = DefaultMockOrchestrationContext(); | ||
|
|
||
| var activitySequence = new MockSequence(); | ||
|
|
||
| mockOrchestrationContext | ||
| .InSequence(activitySequence) | ||
| .Setup(context => | ||
| context.CallActivityAsync(ActivityNames.UpdateFileStoragePath, | ||
| mockOrchestrationContext.Object.InstanceId, | ||
| null)) | ||
| .Throws<Exception>(); | ||
|
|
||
| mockOrchestrationContext | ||
| .InSequence(activitySequence) | ||
| .Setup(context => | ||
| context.CallActivityAsync(ActivityNames.HandleProcessingFailure, | ||
| mockOrchestrationContext.Object.InstanceId, | ||
| null)) | ||
| .Returns(Task.CompletedTask); | ||
|
|
||
| await ProcessCompletionOfNextDataSetVersionImport(mockOrchestrationContext.Object); | ||
|
|
||
| VerifyAllMocks(mockOrchestrationContext); | ||
| } | ||
|
|
||
| private static async Task ProcessCompletionOfNextDataSetVersionImport( | ||
| TaskOrchestrationContext orchestrationContext) | ||
| { | ||
| await ProcessCompletionOfNextDataSetVersionOrchestration.ProcessCompletionOfNextDataSetVersionImport( | ||
| orchestrationContext, | ||
| new ProcessDataSetVersionContext { DataSetVersionId = Guid.NewGuid() }); | ||
| } | ||
|
|
||
| private static Mock<TaskOrchestrationContext> DefaultMockOrchestrationContext(Guid? instanceId = null) | ||
| { | ||
| var mock = new Mock<TaskOrchestrationContext>(MockBehavior.Strict); | ||
|
|
||
| mock.Setup(context => | ||
| context.CreateReplaySafeLogger( | ||
| nameof(ProcessCompletionOfNextDataSetVersionOrchestration | ||
| .ProcessCompletionOfNextDataSetVersionImport))) | ||
| .Returns(NullLogger.Instance); | ||
|
|
||
| mock.SetupGet(context => context.InstanceId) | ||
| .Returns(instanceId?.ToString() ?? Guid.NewGuid().ToString()); | ||
|
|
||
| return mock; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.