Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation typos #49

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Fix documentation typos #49

merged 4 commits into from
Sep 12, 2024

Conversation

cjrace
Copy link
Contributor

@cjrace cjrace commented Sep 12, 2024

Brief overview of changes

Adding the spelling package into the checks on the package and fixed up a few typos I spotted.

Why are these changes being made?

Noticed a couple of typos when promoting the external_link() function and figured I'd quickly fix them, as well as add the spelling checks to prevent more going forwards.

Detailed description of changes

No extra detail needed

Additional information for reviewers

Made it a dev version as it's not worth a version bump (only the typos are user facing, the rest is all behind the scenes) and these can just go into our next update.

Issue ticket number/s and link

No related issue number

@cjrace cjrace marked this pull request as ready for review September 12, 2024 11:34
tests/spelling.R Fixed Show resolved Hide resolved
tests/spelling.R Fixed Show resolved Hide resolved
R/cookies.R Outdated Show resolved Hide resolved
Copy link
Contributor

@jen-machin jen-machin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny change!

@cjrace cjrace merged commit 0de4922 into main Sep 12, 2024
10 checks passed
@cjrace cjrace deleted the fix-documentation-typos branch September 12, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants