Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #18

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Update README.md #18

merged 2 commits into from
Feb 13, 2024

Conversation

cjrace
Copy link
Contributor

@cjrace cjrace commented Feb 10, 2024

This is to undo what I had previously done in #9, and explained in dfe-analytical-services/shiny-template#70.

Having re-read the guidance on renv::install() (and other guidance more generally) to try to troubleshoot issues in deployment pipelines with the alternative install of dfeshiny, it seems that the original method was the recommended one.

image

Given this, and starting to bang my head against a wall a bit, I switched to trying to work out my original error I was having locally (along with some others). Time to hold my hands up and admit I should have persevered with this more in the first place...

  • I had a rogue .Renviron file that was in my onedrive documents folder from years ago setting an outdated GitHub PAT (amongst other things)
  • I hadn't considered this as I'd moved to a new laptop recently, and didn't know I had anything set in onedrive folders that would have carried over to the new laptop

It now works with the original instructions. I've added a quick note at the bottom of the README too, to help others who may hit this issue.

@cjrace cjrace marked this pull request as ready for review February 10, 2024 10:06
@cjrace cjrace requested a review from rmbielby February 10, 2024 10:06
@cjrace cjrace merged commit 136b898 into main Feb 13, 2024
2 checks passed
@cjrace cjrace deleted the update-readme-to-original-install branch February 13, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants