Add numberstring as an acceptable indicator_unit #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmbielby
previously approved these changes
Sep 6, 2024
Merge branch 'main' into add-numberstring # Conflicts: # manifest.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
Adding numberstring as an acceptable indicator_unit.
Why are these changes being made?
We'd added it into EES this week, so the screener should match to allow users to use it.
Detailed description of changes
Added numberstring as an acceptable value
Added new test data and test that contains all indicator units to make sure they pass
Minimised the existing test data for indicator units to reduce size
Additional information for reviewers
Links to dfe-analytical-services/analysts-guide#83 as a complementary guidance change, which explains the behaviour.
Issue ticket number/s and link
None