-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: laminas (original, original-wordmark, line, line-wordmark) #2246
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall excellent work, just a few minor comments that have to be resolved.
icons/laminas/laminas-line.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devicon.json
Outdated
"line-wordmark" | ||
], | ||
"font": [ | ||
"original" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add, original-wordmark
, line
, and line-wordmark
here as all 3 can be converted into font versions.
@canaleal
I've committed these changes and pushed them to the repository. The pull request now shows 2 commits. Could you please review the changes again? Let me know if any further modifications are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work 💯
Just added another commit to fix some line artifacts on icomoon for the line SVGs.
Double check these details before you open a PR
develop
branch.devicon.json
file at the correct alphabetic position as seen hereThis PR closes #2234
Link to prove your SVG is correct and up-to-date.
https://getlaminas.org/