(iOS) Added preferences for privacy on background only and overriding LaunchImage #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…background mode as activating in resign activates privacy in cases where it may not be required (i.e. touch ID prompt).\n (iOS) added option “PrivacyOverrideLaunchImage” to be able to use images that are different from the launch screen even when this exists.
…\n changed version to 0.3.4.\n Updated README.md.
Changed plugin lifecycle.
Fixed bug with responding to wrong function on page load.\n Added timer preference.\n Show Privacy screen hides after timer.
|
I would have liked the fix for the Touch ID issue, but wish it hadn't been wrapped up with another feature. Maybe you could find a way to make this two different PRs? |
Added screen sizes for 2x and 3x density using system like splash screen (launch screen)
Added iPhoneX to device struct
Removed '-' from calculated privacy screen images names; Support for iPhoneX screen size; Removed support for Launch Screen Storyboard;
Update PrivacyScreenPlugin.m
Update PrivacyScreenPlugin.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In iOS activating privacy in WillResign method generates a behavior that isn't desirable in current project I'm working on (i.e. Shows privacy screen in Touch ID prompt), as such a preference "PrivacyOnBackground" is now checked, if it is true then privacy screen is only activated on background.
Another preference "PrivacyOverrideLaunchImage" has been added so that even if a launch image is set, if this preference is true it overrides to the "Default" image.
Related Issue
#33
Motivation and Context
On our app that uses this plugin, when the Touch Id Prompt was launched the privacy screen blocked the app view.
The app has a launch image, but it has been defined in our app that the privacy screen must be different
How Has This Been Tested?
Manual testing to check if intended behavior was added, manual testing to check if previous behavior was kept without changes to current users of the plugin.
Screenshots (if appropriate):
Types of changes
Checklist: