Forums explore fixes #268
Merged
Forums explore fixes #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Forums Explore page, the 'Add a Post' header beside the add icon was split in two lines due to less spacing. This commit fixes this by giving more spacing to the header, hence resulting in the header to fit in one line without breaking.
…r/thapar_app into forums-explore-fixes
associated file From the Forums Explore page, clicking on a question independent of a file gave you a critical error, since FileSideView component was being rendered, and it expected many parameters such as the thumbnail of the file, whereas in reality the file property of the question was null. To resolve this, FileSideView component is rendered only if the particular question has a file associated with it.
|
LGTM! |
aniketbiswas21
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #267