Update feature asdf-package to allow installing multiple packages #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @danielbraun89, just wanted to check in on your thoughts regarding this PR. Thanks! |
|
Any updates on this @danielbraun89 @natescherer, would be great to get something in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is an update to the asdf-package feature to allow installing multiple packages since currently the same feature can't be run multiple times in a devcontainer.json.
I bumped the version to 2.0.0 as I didn't see a way around making breaking changes to the options provided to the feature. this should mean anything that's using ghcr.io/devcontainers-contrib/features/asdf-package:1 won't break, and people will need to manually update to v2.
Happy to make changes/answer questions. Also, if you think this is too big of a change to the function, I'm happy to offer this modified version out of my own features repo.