Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cavity __repr__ printing volate for phase #121

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Feb 2, 2024

Description

Fixes the __repr__ bug in Cavity as found in #120.

Motivation and Context

Closes #120.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@jank324 jank324 added the bug Something isn't working label Feb 2, 2024
@jank324 jank324 linked an issue Feb 2, 2024 that may be closed by this pull request
@jank324 jank324 marked this pull request as ready for review February 2, 2024 11:42
@jank324 jank324 merged commit 398b123 into master Feb 2, 2024
9 checks passed
@jank324 jank324 deleted the 120-cavity-__repr__-is-printing-voltage-for-phase branch February 2, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cavity __repr__ is printing voltage for phase
1 participant