Skip to content

Commit

Permalink
114 tests are failing on gpu machine (#115)
Browse files Browse the repository at this point in the history
* Add test to find Ocelot conversion device issue

* Fix tests on CPU-only machine

* Add test to check that torch to method works

* Fix formatting

* Remove element device property

* Fix how types and devices are handled

* Fix tests failing on GPU machine

* Fix formatting

* Update changelog

* Add convenient device and dtype args to Ocelot import

* Fix screen extent computation return type

* Add test for float64 tracking; Remove some large rtol in tests

---------

Co-authored-by: Chenran Xu <[email protected]>
  • Loading branch information
jank324 and cr-xu authored Dec 19, 2023
1 parent 6512fb0 commit 2549df9
Show file tree
Hide file tree
Showing 12 changed files with 543 additions and 421 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### 🚨 Breaking Changes

None
- The handling of `device` and `dtype` was overhauled. They might not behave as expected. `Element`s also no longer have a `device` attribute. (see #115) (@jank324)

### 🚀 Features

Expand All @@ -15,7 +15,7 @@ None

- Fix the transfer maps in `Drift` and `Dipole`; Add R56 in horizontal and vertical correctors modelling (see #90) (@cr-xu)
- Fix fringe_field_exit of `Dipole` is overwritten by `fringe_field` bug (see #99) (@cr-xu)
- Fix error caused by mismatched devices on machines with CUDA GPUs (see #97) (@jank324)
- Fix error caused by mismatched devices on machines with CUDA GPUs (see #97 and #115) (@jank324)
- Fix error raised when tracking a `ParameterBeam` through an active `BPM` (see #101) (@jank324)
- Fix error in ASTRA beam import where the energy was set to `float64` instead of `float32` (see #111) (@jank324)
- Fix missing passing of `total_charge` in `ParameterBeam.transformed_to` (see #112) (@jank324)
Expand Down
Loading

0 comments on commit 2549df9

Please sign in to comment.