[TS typings] Allow model.ref's to param to be a Query or Filter, to match implementation #311

ericyhwang · 2024-07-18T20:55:02Z

The implementation of model.ref allows the to param to be a Query or Filter. In those cases, it calls that query or filter object's ref method:

Lines 259 to 260 in d8fbfcd

    
           // Make ref to reffable object, such as query or filter 
        
           if (!toPath) return to.ref(fromPath);

This updates the TypeScript typings for model.ref to allow that use-case.

…atch runtime behavior

[TS typings] Allow model.ref's to param to be a Query or Filter, to m…

29b09cd

…atch runtime behavior

ericyhwang requested a review from craigbeck July 18, 2024 20:55

craigbeck approved these changes Jul 19, 2024

View reviewed changes

ericyhwang merged commit b4992ed into master Jul 19, 2024
10 checks passed

ericyhwang deleted the ref-query-filter branch July 19, 2024 18:38

Provide feedback

	// Make ref to reffable object, such as query or filter
	if (!toPath) return to.ref(fromPath);