Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MeetingEntity와 MeetingRepository 개발 #8

Merged
merged 7 commits into from
Dec 29, 2023
Merged

feat: MeetingEntity와 MeetingRepository 개발 #8

merged 7 commits into from
Dec 29, 2023

Conversation

ddingmin
Copy link
Member

@ddingmin ddingmin commented Dec 28, 2023 •
edited
Loading

🚀 어떤 기능을 개발했나요?

Meeting 도메인과 Repository를 구현했습니다.

🕶️ 어떻게 해결했나요?

  • Meeting 도메인 개발
  • FlyWay DDL 구현 및 auto_increment 추가
  • FlyWay H2 테스트 DB 방언 변경 (H2 -> MySQL)

🦀 이슈 넘버

close #6

(option) 어떤 부분에 집중하여 리뷰해야 할까요?

  • 모임 도메인 빠진 부분이 있는지 확인해주세요.
  • 부족한 검증 로직이 존재하는지 확인해주세요.

@ddingmin ddingmin self-assigned this Dec 28, 2023
devxb
devxb approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@devxb devxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR제목이랑 본문에 user로 되어있는거만 meeting? 으로 수정해주세용

@ddingmin ddingmin changed the title feat: UserEntity와 UserRepository 개발 feat: MeetingEntity와 MeetingRepository 개발 Dec 29, 2023
@ddingmin ddingmin merged commit 59ae582 into develop Dec 29, 2023
1 check passed
@ddingmin ddingmin deleted the feature/iss-#6 branch December 29, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxb devxb devxb approved these changes

@choidongkuen choidongkuen Awaiting requested review from choidongkuen choidongkuen is a code owner

Assignees

@ddingmin ddingmin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 모임 도메인 작성
2 participants
@ddingmin @devxb