OvhRequestApi: Ensure to escape querystring arguments #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [MAJOR] previously, only the first querystring argument was sent to OVH API,
because ampersand was interpreted as shell background job, so other arguments ignored
misc:
- [MINOR] fix jsonsh-lib about AWK pattern warning
|
hi @denouche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @denouche
I'm always using ovh-api-bash-client, and I've freshly discovered a major bug in
OvhRequestApi()When calling an URL with at least two arguments, only the first was forwarded to the main script, and so to OVH API
So, something like
/action?foo=bar&baz=123was forwarded as/action?foo=barThe function
updateSignData()allowed me to understand what's happened to the querystringHere is a little fix for a useful improvement.
Regards !