Network endpoints #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and sorry for the unsolicited PR.
I've been using your library for a project, and I ended up needing some additional endpoints and other features dealing with docker networking. I've implemented them, and I'm currently using them on my own fork, but I thought I would make them available to you guys, in case you were interested in merging them. I'm happy to make changes, if it would help get this merged, as it would be nice to be able to use the Hackage version of your library for my project.
Here is a list of the endpoints I've implemented:
listNetworksinspectNetworksconnectNetworkdisconnectNetworkpruneNetworksIn addition, I've filled out the
CreateNetworkOptsfields forcreateNetwork, to allow for more configurability on network creation. I've also added integration tests for the new features.Thanks.