Implement recurring events and todos #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decided to not use the sexp approach because ox-icalendar doesn't seem to support exporting them, which would make 2 way sync impossible
This reverts commit 961f300.
Everything seems to work now. Just need to add some unit tests
This was referenced Sep 8, 2024
|
Awesome! Sorry, I didn't find the time to test this before merging, but I'm looking forward to trying it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
This seems to be working, but I plan to add some unit tests before merging.
Also should update the documentation to note this is supported now, but only for simple cases (no iCal UNTIL or COUNT properties), and also to note some subtleties in the case of TODOs (e.g. the user may want to set
org-icalendar-todo-unscheduled-start).I'm opening the PR now for visibility and so people can test it out if they like.