Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less vertical empty space for img attachments #4216

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxphilippov
Copy link
Collaborator

Make wide but short image attachments display nicer.

Before:
image
After:
image

CHANGELOG.md Outdated Show resolved Hide resolved
@Simon-Laux
Copy link
Member

I think the remaining padding is also weird. I think the image should go right to the corners (unless text is larger).
What do you think @r10s? how do dc-iOS and dc-android handle image with caption / forwarded header?

Some background on the current state: I believe we needed fixed height at some point to prevent the message list from jumping around while loading images (when it changes message height).

Co-authored-by: bjoern <[email protected]>
@maxphilippov maxphilippov marked this pull request as draft October 16, 2024 10:09
@maxphilippov
Copy link
Collaborator Author

Some background on the current state: I believe we needed fixed height at some point to prevent the message list from jumping around while loading images (when it changes message height).

Oh, make sense, I'll look for a better solution then

@r10s
Copy link
Member

r10s commented Oct 16, 2024

I think the remaining padding is also weird. I think the image should go right to the corners

agree. usually, this also happens

how do dc-iOS and dc-android handle image with caption / forwarded header?

looks like the following on android:

Screenshot 2024-10-16 at 12 19 36

ios is similar wrt image sizes, the text is show in an transparent overlay there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants