Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core to 1.147 #4194

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Update core to 1.147 #4194

merged 8 commits into from
Oct 15, 2024

Conversation

nicodh
Copy link
Contributor

@nicodh nicodh commented Oct 9, 2024

No description provided.

@nicodh nicodh requested a review from Simon-Laux October 9, 2024 14:45
According to CHANGELOG core does not support it any more since 1.143

"Remove old iroh 0.4 and support for old `DCBACKUP` QR codes."
@nicodh nicodh marked this pull request as draft October 9, 2024 22:06
@nicodh
Copy link
Contributor Author

nicodh commented Oct 9, 2024

Seems we have to adapt settings first. At least step 1 from #4124

@nicodh
Copy link
Contributor Author

nicodh commented Oct 11, 2024

Step 1 of #4124 is included here now:

image

@nicodh nicodh marked this pull request as ready for review October 11, 2024 08:47
@nicodh nicodh requested a review from iequidoo October 11, 2024 08:49
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did a quick functionality check and could manage to connect via ss://[email protected]:443#Switzerland%20#1270%20/%20OutlineKeys.com - nice!

for the UI: as this is subject to change anyways and will do to a dedicated dialog, it is good enough for now.

for the strings: they are available already translated, no need to add them to "untranslated".
for the "placeholder", i'd strike that for now, that seems more confusing and cluttering than helpful - ppl will have a proxy URL from some sources and needs and will paste them here - and not the other way round. also, already now it is incomplete as ss is missing.
if we think, a placeholder is useful, let's start with that on android, where we move ahead with proxy settings and collect more experiences.

i cannot say much to the rest of the code

@nicodh
Copy link
Contributor Author

nicodh commented Oct 12, 2024

for the strings: they are available already translated, no need to add them to "untranslated".

where can I check what is already translated?
Do I need to become member in the transifex DeltaChat project?

How do we import the new strings then? Otherwise the preview would miss the labels...

@nicodh
Copy link
Contributor Author

nicodh commented Oct 12, 2024

for the "placeholder", i'd strike that for now, that seems more confusing and cluttering than helpful -

I agree - at least as long the placeholder has the same styling than the entered text

@r10s
Copy link
Member

r10s commented Oct 14, 2024

note that there is 1.147.1 meanwhile, 1.147.0 contained a bug that resulted in some incompatibilities with existing releases, see deltachat/deltachat-core-rust#6038

@nicodh nicodh merged commit d6a30a9 into main Oct 15, 2024
10 checks passed
@nicodh nicodh deleted the update-core-1.147 branch October 15, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants