blocked users in chatlist menu #4189
Conversation
- new useViewProfileMenu menu with two items: * Edit Contact Name * Block/Unblock Contact * Encryption Info - minor refactor of useChatDialog, so we don't have to have a ChatListItem to block contact or get EncryptionInfo - resolves #4043
- if you open a chat for blocked contact the context menu properly reacts to to use block and displays "Unblock Contact" - resolves #4046
maxphilippov
changed the title
the chat's menu is "Block Contact" and the profile menu is "Unblock Content". this is somehow wrong. but in general: "Block Contact" removes the one-to-one-chat on purpose. if you now re-create the one-to-one-chat, using "Send Message" and also send a messages, it seems a bit unexpected, that the contact is still blocked and you cannot see eg. the answer (imagine you ask the user to be friends again :) not sure, if this is a desktop-only-issue, however. maybe we can also unblock in core, in case a private message is sent to a user |
per request, here is a video. this is what it looks on current master for me: Screen.Recording.2024-10-15.at.19.12.49.mov |
|
Hmm, I thought that was solved with #4147 where we had the same contradictory menu items... ? |
No, I've mentioned that this might require more work and it was a part of another issue, so it's another PR. |
So this is kinda up for discussion. There's an issue #4046, short summary:
ChatList(on the left), but when you open a context menu on this chat there's only "Block Contact"This is a draft implementation for the context menu to show "Unblock Contact" at least. That at least makes menu behavior "correct" and allows you to do "Unblock Contact" > "Block Contact" again to hide the chat. That's extremely cumbersome so it's up for a discussion if this "correct behavior" is required at all.
I can see how you might need to open a chat with blocked contact and I'm not sure if it should go away automatically if you select another chat.
Depends on #4147