Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: lower contrast for a border in dark theme #4177

Merged
merged 1 commit into from
Oct 5, 2024
Merged

style: lower contrast for a border in dark theme #4177

merged 1 commit into from
Oct 5, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Oct 5, 2024

When quoting a message.
In the default dark theme was way too bright.

Before:

image

After:

image

@WofWca WofWca requested a review from Simon-Laux October 5, 2024 15:09
r10s
r10s approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good! thanks a lot!

that UI style bug also hit my eyes, but i did not came with an issue, let alone fix yet :)
i also did a quick test, works as expected :)

@WofWca
style: lower contrast for a border in dark theme
a390c8f 
When quoting a message.
In the default dark theme was way too bright.
@WofWca WofWca merged commit b5c3eb6 into main Oct 5, 2024
7 checks passed
@WofWca WofWca deleted the wofwca/quote-border-color branch October 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

@Simon-Laux Simon-Laux Awaiting requested review from Simon-Laux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WofWca @r10s