Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sticker reply background to make name more readable #4143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change sticker reply background to make name more readable #4143

wants to merge 1 commit into from

Conversation

maxphilippov
Copy link
Collaborator

@maxphilippov maxphilippov mentioned this pull request Sep 21, 2024
Open
@maxphilippov
Copy link
Collaborator Author

maxphilippov commented Sep 21, 2024 •
edited
Loading

I tried making it a text color but for me on Windows but the name was blending with text. And I personally find color-coding useful to quickly search through the group dialogs. It might confuse something if that's a message not a quote, so I need feedback on this one.

Originally posted by @maxphilippov in #3291 (comment)

nicodh
nicodh approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@nicodh nicodh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (also tested). Concerning the colors: incomingMsgBg makes sense to me. It will have the same contrast as other incoming messages, and the contrast in the sent message is not that relevant since it shows my own name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicodh nicodh nicodh approved these changes

@r10s r10s Awaiting requested review from r10s

@Simon-Laux Simon-Laux Awaiting requested review from Simon-Laux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hard to read color in quoted message with sticker reply
2 participants
@maxphilippov @nicodh