Use the SDK V3 Style #794
Merged
Use the SDK V3 Style #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resonious
reviewed
Aug 18, 2023
schedule_handler.js
Outdated
| @@ -1,11 +1,12 @@ | |||
| var AWS = require('aws-sdk'); | |||
| import { ECSClient, RunTaskCommand } from "@aws-sdk/client-ecs"; | |||
|
|
|||
| var util = require('util'); | |||
|
|
|||
| exports.handler = function(input, context) { | |||
There was a problem hiding this comment.
Suggested change
| exports.handler = function(input, context) { | |
| exports.handler = async function(input, context) { |
Since there's an await down below, we'll need this to be async.
There was a problem hiding this comment.
Nice catch. Thanks
|
@essa can you help us review this PR, please? |
essa
reviewed
Aug 18, 2023
barcelona.yml
Outdated
| # 10AM JST every week day | ||
| - schedule: cron(0 1 ? * MON-FRI *) | ||
| command: bin/chaos | ||
| scheduled_tasks: [] |
There was a problem hiding this comment.
You are removing all scheduled task now?
There was a problem hiding this comment.
No, sorry let me remove that
essa
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new node version uses SDK V3. This comes with a new import method.