Resource based s3:GetObject ACL for container instances #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k2nr
force-pushed
the
restrict-instance-s3-permissions
branch
from
1bca7e2
to
b12f46b
Compare
|
@k2nr I think you can close this. S3 access is dependent upon policies for a given user. Unless this is for something different |
|
Container instances currently have full permission for "s3:GetObject". This is very dangerous because credential data are stored in S3. there are only a few objects that container instances need to get. This PR is to minimize the container instance's get permission |
|
I think with a little bit of checking that it works we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container instances must have minimum-required access to S3. Before merging this, we need to make sure that all of our services have ECS task role (services that have not deployed for a long time might not have a task role)