Skip to content

Commit

Permalink
remove logentries from code
Browse files Browse the repository at this point in the history
  • Loading branch information
Frank Mata committed Jun 29, 2023
1 parent 8260568 commit 3a0714c
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 85 deletions.
3 changes: 0 additions & 3 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ Naming/HeredocDelimiterNaming:
- 'bin/bootstrap'
- 'lib/barcelona/network/bastion_builder.rb'
- 'lib/barcelona/plugins/itamae_plugin.rb'
- 'lib/barcelona/plugins/logentries_plugin.rb'
- 'lib/barcelona/plugins/newrelic_plugin.rb'
- 'lib/barcelona/plugins/ossec_client_plugin.rb'
- 'lib/barcelona/plugins/pcidss_plugin.rb'
Expand Down Expand Up @@ -319,7 +318,6 @@ Security/YAMLLoad:
Exclude:
- 'spec/lib/barcelona/plugins/datadog_plugin_spec.rb'
- 'spec/lib/barcelona/plugins/itamae_plugin_spec.rb'
- 'spec/lib/barcelona/plugins/logentries_plugin_spec.rb'
- 'spec/lib/barcelona/plugins/newrelic_plugin_spec.rb'
- 'spec/lib/barcelona/plugins/ossec_client_plugin_spec.rb'
- 'spec/lib/barcelona/plugins/pcidss_plugin_spec.rb'
Expand Down Expand Up @@ -416,7 +414,6 @@ Style/MutableConstant:
- 'lib/barcelona/network/subnet_builder.rb'
- 'lib/barcelona/network/vpc_builder.rb'
- 'lib/barcelona/plugins/datadog_logs_plugin.rb'
- 'lib/barcelona/plugins/logentries_plugin.rb'
- 'lib/barcelona/plugins/pcidss_plugin.rb'

# Offense count: 1
Expand Down
68 changes: 0 additions & 68 deletions lib/barcelona/plugins/logentries_plugin.rb

This file was deleted.

4 changes: 2 additions & 2 deletions spec/factories/plugins.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FactoryBot.define do
factory :plugin do
name { "logentries" }
plugin_attributes { { token: 'logentriestoken' } }
name { "datadog" }
plugin_attributes { { api_key: 'datadogapikey' } }
end
end
8 changes: 4 additions & 4 deletions spec/models/plugin_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
end

context "when plugin class exists" do
let(:name) { "logentries" }
let(:name) { "datadog" }
it { expect(plugin).to be_valid }
end
end
Expand All @@ -19,15 +19,15 @@
context "when plugin class doesnt exist" do
let(:name) { "wrong" }
it "calls plugin method" do
expect_any_instance_of(Barcelona::Plugins::LogentriesPlugin).to_not receive(:hook)
expect_any_instance_of(Barcelona::Plugins::DatadogPlugin).to_not receive(:hook)
expect(plugin.hook(:trigger, nil, "argument")).to eq "argument"
end
end

context "when plugin class exists" do
let(:name) { "logentries" }
let(:name) { "datadog" }
it "calls plugin method" do
expect_any_instance_of(Barcelona::Plugins::LogentriesPlugin).to receive(:hook)
expect_any_instance_of(Barcelona::Plugins::DatadogPlugin).to receive(:hook)
plugin.hook(:trigger, nil)
end
end
Expand Down
16 changes: 8 additions & 8 deletions spec/requests/plugin_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,29 @@
describe "PUT /districts/:district/plugins/:id", type: :request do
let(:user) { create :user }
let(:district) { create :district }
let(:name) { "logentries" }
let(:name) { "datadog" }

given_auth(GithubAuth) do
it "puts a plugin" do
# create
params = {attributes: {token: "abcde"}}
params = {attributes: {api_key: "abcde"}}
api_request :put, "/v1/districts/#{district.name}/plugins/#{name}", params
expect(response.status).to eq 200

plugin = JSON.load(response.body)["plugin"]
expect(plugin["name"]).to eq "logentries"
expect(plugin["attributes"]).to eq({"token" => "abcde"})
expect(plugin["name"]).to eq "datadog"
expect(plugin["attributes"]).to eq({"api_key" => "abcde"})

# update
params = {attributes: {token: "fghijk"}}
params = {attributes: {api_key: "fghijk"}}
api_request :put, "/v1/districts/#{district.name}/plugins/#{name}", params
expect(response.status).to eq 200

plugin = JSON.load(response.body)["plugin"]
expect(plugin["name"]).to eq "logentries"
expect(plugin["attributes"]).to eq({"token" => "fghijk"})
expect(plugin["name"]).to eq "datadog"
expect(plugin["attributes"]).to eq({"api_key" => "fghijk"})

expect(district.plugins.pluck(:name)).to eq ["logentries"]
expect(district.plugins.pluck(:name)).to eq ["datadog"]

# delete
api_request :delete, "/v1/districts/#{district.name}/plugins/#{name}", params
Expand Down

0 comments on commit 3a0714c

Please sign in to comment.