feat: use solhint features #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xShaito
commented
Sep 4, 2024
src/interfaces/.solhint.json
Outdated
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "rules": { | |||
| "ordering": "off", | |||
There was a problem hiding this comment.
Should we keep ordering on in interfaces?
There was a problem hiding this comment.
I like having a standard for interface ordering; following the layout from the Solidity docs convinces me—at the same time, I prefer putting default getters above other functional logic. I think this last preference conflicts with how ordering works.
Comment on lines
2
to
3
| "extends": "solhint:recommended", | ||
| "rules": { |
There was a problem hiding this comment.
I vote for warning on named-parameters-mapping rule. A shout-out to @0xteddybear for noticing it.
gas1cent
reviewed
Oct 3, 2024
| "func-visibility": ["warn", { "ignoreConstructors": true }], | ||
| "not-rely-on-time": "off", |
There was a problem hiding this comment.
@0xteddybear why removing this rule ser?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features in solhint allows us to implement different rules for different folders. Now we have a general one and a specific one on each folder. With this, we remove a lot of defaults that are not needed anymore and create a separation of rules