feat: update solidity exporter #79
Conversation
.github/workflows/canary.yml
Outdated
| with: | ||
| # Update package_name with your package name | ||
| package_name: 'my-cool-project' | ||
| package_name: ${{ env.PROJECT_NAME }} |
There was a problem hiding this comment.
Missing var on .env.example
There was a problem hiding this comment.
or does it need to be a secret instead?
There was a problem hiding this comment.
I'd name the var NPM_PACKAGE_NAME to make its meaning completely obvious.
There was a problem hiding this comment.
@0xDiscotech the var is defined in the same action. Not on the .env file
There was a problem hiding this comment.
@gas1cent in this case, it would append -interfaces if you only get the interfaces or keep the project name only for the other case. Do you think it's still better to have the variable be NPM_PACKAGE_NAME? (As it won't be the actual name for the interfaces)
There was a problem hiding this comment.
I'd name the var
NPM_PACKAGE_NAMEto make its meaning completely obvious.
As @0xShaito mentioned, NPM_PACKAGE_NAME is not accurate in those cases in which -interfaces gets appended to the published package name.
No description provided.