Add more example and pip install commands to README.md #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
deeplook
reviewed
Dec 3, 2023
| @@ -175,7 +191,7 @@ With the ``pip`` command on your system and a working internet | |||
| connection you can install the newest version of ``svglib`` with only | |||
| one command in a terminal:: | |||
|
|
|||
| $ pip install svglib | |||
| $ pip install svglib rlPyCairo reportlab | |||
There was a problem hiding this comment.
reportlab is listed as a dependency in requirements.txt so it should not be needed here.
deeplook
reviewed
Dec 4, 2023
|
|
||
| .. code:: python | ||
|
|
||
| from svglib.svglib import svg2rlg |
There was a problem hiding this comment.
Nitpicking, but this order would be a more recommended one: stdlib, external, and local packages, not split with empty lines here for brevity:
import io
from PIL import Image
from reportlab.graphics import renderPM
from svglib.svglib import svg2rlg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#391