Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml #378

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add pyproject.toml #378

wants to merge 1 commit into from

Conversation

claudep
Copy link
Collaborator

@claudep claudep commented Jun 2, 2023

setup.py is obsolete nowadays and replaced by pyproject.toml (PEP 518).

setup.py is obsolete nowadays and replaced by pyproject.toml (PEP 518).
@deeplook
Copy link
Owner

deeplook commented Jun 3, 2023

I'm fine with moving to pyproject.toml, although I'm quite sure that support for setup.py will not vanish really soon. But this PR removes instructions for installation without pip from a locally downloaded package, though, if I'm not mistaken. Or am I missing something?

@claudep
Copy link
Collaborator Author

claudep commented Jun 5, 2023

Instead of removing the section, I should have moved the downloaded package installation from setup.py to pip.

Anyway, I think there is a unrelated reportlab installation issue in the test suite, so putting this as WIP until it's fixed.

@claudep claudep marked this pull request as draft June 5, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants