build: Introduce gradle version catalog #5683
Conversation
devinrsmith
added
build
NoDocumentationNeeded
dependencies
devinrsmith
changed the title
devinrsmith
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
|
I tried to compare the difference between I audited the difference in runtime classpath using |
| @@ -14,8 +14,8 @@ dependencies { | |||
| testImplementation project(path: ':Base', configuration: 'tests') | |||
|
|
|||
| testRuntimeOnly project(':log-to-slf4j') | |||
There was a problem hiding this comment.
libs.XYZ is pretty nice, in that it's based on a symbol rather a string. I wonder if we could do similarly for project dependencies.
There was a problem hiding this comment.
I mean its groovy, you can do just about anything. I believe I've seen this done on some other projects, I'll see if I can find where I saw it.
| @@ -14,8 +14,8 @@ dependencies { | |||
| testImplementation project(path: ':Base', configuration: 'tests') | |||
|
|
|||
| testRuntimeOnly project(':log-to-slf4j') | |||
There was a problem hiding this comment.
I mean its groovy, you can do just about anything. I believe I've seen this done on some other projects, I'll see if I can find where I saw it.
| } | ||
|
|
||
| dependencies { | ||
| implementation(libs.hadoop.common) { |
There was a problem hiding this comment.
I didn't realize this had moved to Classpaths - I don't love that it's a plugin, but better than repeating it in two places.
This is the first step in modernizing our gradle dependency management by using a gradle version catalog; this PR migrates all of our bespoke
Classpaths.groovyversions into a standardizedlibs.versions.toml.The biggest benefit is that dependabot will be able to submit gradle dependency version bump PRs. As developers, we should also benefit from greater standardization (IntelliJ works as you would expect with autocomplete, click-through, and find usages support).
The learning curve should be relatively small.
The intention is to continue the migration to the version catalog. Additional dependencies we declare outside of
Classpaths.groovyshould be relatively straightforward to migrate.Fixes #5177