Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SafeCloseable context manager wrapper #5251

Merged
merged 9 commits into from
Mar 16, 2024
Merged

Add SafeCloseable context manager wrapper #5251

merged 9 commits into from
Mar 16, 2024

Commits on Mar 14, 2024

  1. Add SafeCloseable wrapper

    @arman-ddl
    arman-ddl committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c12ecf3 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Add SafeCloseable test

    @arman-ddl
    arman-ddl committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fbc4609 View commit details
    Browse the repository at this point in the history

  2. Extend JObjectWrapper

    @arman-ddl
    arman-ddl committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    66fcfc8 View commit details
    Browse the repository at this point in the history

  3. Polish

    @arman-ddl
    arman-ddl committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2d54701 View commit details
    Browse the repository at this point in the history

  4. Polish

    @arman-ddl
    arman-ddl committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8bb8664 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Per @chipkent.

Co-authored-by: Chip Kent <[email protected]>
    @arman-ddl @chipkent
    arman-ddl and chipkent authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ae90b46 View commit details
    Browse the repository at this point in the history

  6. Document assumption

    @arman-ddl
    arman-ddl committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    95e599a View commit details
    Browse the repository at this point in the history

  7. Polish pydoc 

    Co-authored-by: Chip Kent <[email protected]>
    @arman-ddl @chipkent
    arman-ddl and chipkent authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2b70878 View commit details
    Browse the repository at this point in the history

  8. Change SafeCloseable to AutoCloseable

    @arman-ddl
    arman-ddl committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    67421f4 View commit details
    Browse the repository at this point in the history