Skip to content

Commit

Permalink
Enforce DEEPFENCE_FILE_SERVER_PORT to be a string (#2331)
Browse files Browse the repository at this point in the history
ConfigMap in version "v1" cannot be handled as a ConfigMap: json: cannot unmarshal number into Go struct field ConfigMap.data of type string

due to the template not quoting the port for an external S3 instance, the configmap will not be able to be applied

add quoting to the value for the port
  • Loading branch information
psych0d0g authored and ramanan-ravi committed Oct 5, 2024
1 parent 410aad2 commit c13e647
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ data:
DEEPFENCE_FILE_SERVER_EXTERNAL: "false"
{{- else }}
DEEPFENCE_FILE_SERVER_HOST: {{ .Values.fileserver.fileServerHost }}
DEEPFENCE_FILE_SERVER_PORT: {{ .Values.fileserver.fileServerPort }}
DEEPFENCE_FILE_SERVER_PORT: {{ .Values.fileserver.fileServerPort | quote }}
DEEPFENCE_FILE_SERVER_EXTERNAL: "true"
{{- end }}

Expand Down

0 comments on commit c13e647

Please sign in to comment.