Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: make avatar model x position responsive #2261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RominaMarchetti
Copy link
Contributor

@RominaMarchetti RominaMarchetti commented Oct 1, 2024

What does this PR change?

This PR was created to fix the anchor position of the avatar model, which depending on the screen resolution turns wrong giving as result is a lot of bottom margin as in the following example:

Previous.mov

With this fix, the avatar is always anchored at the left center of the screen
https://github.com/user-attachments/assets/32067437-496d-4d3f-80cb-7d4fd466a659

What's pending?

Scale the avatar model for wide screens to avoid it of being chopped at the top and bottom.

How to test the changes?

  1. Launch the explorer
  2. Play with different screens resolutions on the authentication screen to check the avatar position is now constant.

Copy link

github-actions bot commented Oct 1, 2024

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 6558cc8
Logs https://github.com/decentraland/unity-explorer/actions/runs/11132395718
Download Windows https://github.com/decentraland/unity-explorer/suites/29087110918/artifacts/2003013325
Download Mac https://github.com/decentraland/unity-explorer/suites/29087110918/artifacts/2003472732
Built on 2024-10-01T23:11:54Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant