Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using template cache for branches #2060

Closed
wants to merge 7 commits into from

Conversation

aixaCode
Copy link
Collaborator

@aixaCode aixaCode commented Sep 13, 2024

What does this PR change?

...

How to test the changes?

  1. Launch the explorer
  2. ...

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Summary by CodeRabbit

  • New Features

    • Improved caching logic for new build targets, enhancing efficiency and flexibility in target management.
    • Refined cleanup process for build artifacts, ensuring builds associated with releases are preserved.
  • Bug Fixes

    • Enhanced control flow to prevent unintended cleanup of release builds.
    • Improved retry mechanism for handling errors during target updates, ensuring correct cache strategy is applied.

@aixaCode aixaCode added no QA needed Used to tag pull requests that does not require QA validation do not merge labels Sep 13, 2024
Copy link

coderabbitai bot commented Sep 13, 2024

Warning

Rate limit exceeded

@aixaCode has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 59 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 9c347f0 and 9e77d67.

Walkthrough

The changes introduce modifications to the clone_current_target, generate_body, and get_clean_build_bool functions in the scripts/cloudbuild/build.py file. The clone_current_target function now accepts a use_cache parameter to determine cache utilization. The generate_body function has been updated to use a template cache for new build targets. The get_clean_build_bool function refines the cleanup process by ensuring that build artifacts are only deleted if the build is healthy and not part of a release workflow. These adjustments improve the control over build management based on their status and type.

Changes

Files Change Summary
scripts/cloudbuild/build.py Modified clone_current_target to accept a use_cache parameter; updated generate_body to use a template cache for new build targets; refined cleanup in get_clean_build_bool to conditionally delete artifacts based on build health and release workflow status.

Poem

In the burrow, changes spry,
Targets cached, oh my, oh my!
Clean builds dance, no mess in sight,
Healthy hops, all feels just right.
With a template's gentle grace,
We manage builds in our cozy space! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Sep 13, 2024

badge

New build in progress, come back later!

1 similar comment
Copy link

badge

New build in progress, come back later!

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 28ba5bc and 0d8e361.

Files selected for processing (1)
  • scripts/cloudbuild/build.py (2 hunks)
Additional context used
Ruff
scripts/cloudbuild/build.py

482-483: SyntaxError: Expected ':', found newline

Additional comments not posted (1)
scripts/cloudbuild/build.py (1)

109-111: LGTM!

The code segment correctly implements the logic to create a new build target with a template cache. The print statement confirms the usage of the template cache, which aligns with the AI-generated summary.

scripts/cloudbuild/build.py Outdated Show resolved Hide resolved
@aixaCode aixaCode closed this Sep 13, 2024
@aixaCode aixaCode deleted the chore/unity-cloud-branch-caching branch September 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge no QA needed Used to tag pull requests that does not require QA validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant