Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep link parsing macos patch #2041

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Sep 12, 2024

Re-added missing MacOS deep link parsing patch (mistakenly removed at #1726).

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of the realm parameter for deep links on both Windows and MacOS, addressing trailing slashes and colons for better protocol formatting.
    • Enhanced test coverage for RealmLaunchSettings to ensure correct processing of realm URLs on macOS.

@pravusjif pravusjif added no QA needed Used to tag pull requests that does not require QA validation 1-high Very important but not critical or game breaking sdk labels Sep 12, 2024
@pravusjif pravusjif self-assigned this Sep 12, 2024
Copy link

coderabbitai bot commented Sep 12, 2024

Walkthrough

The changes enhance the ApplicationParametersParser.cs file by improving the handling of the realm parameter extracted from deep links. The update addresses platform-specific issues, adding logic to ensure proper formatting of the realm parameter for MacOS, while maintaining the previous fix for Windows regarding trailing slashes. Additionally, a new test method is introduced to validate this behavior on MacOS, ensuring comprehensive coverage for the RealmLaunchSettings class.

Changes

File Change Summary
Explorer/Assets/Scripts/Global/AppArgs/... Enhanced handling of the realm parameter for MacOS by ensuring proper formatting; retained previous Windows fix for trailing slashes.
Explorer/Assets/Scripts/Global/Tests/EditMode/... Added a test method IgnoreMacOSRealmInvalidation to verify RealmLaunchSettings behavior for realm URLs on MacOS.

Poem

In the realm of code, we hop and play,
Fixing bugs that come our way.
With colons gone, and slashes neat,
Our app now dances, oh so sweet!
A patch for all, both Mac and Windows,
Hooray for changes, let joy bestow! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

badge

New build in progress, come back later!

@pravusjif pravusjif marked this pull request as ready for review September 12, 2024 16:02
@pravusjif pravusjif enabled auto-merge (squash) September 12, 2024 16:04
@pravusjif pravusjif enabled auto-merge (squash) September 12, 2024 16:12
@pravusjif pravusjif merged commit d2884cd into main Sep 12, 2024
4 of 5 checks passed
@pravusjif pravusjif deleted the fix/deep-link-parsing-macos-patch branch September 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-high Very important but not critical or game breaking no QA needed Used to tag pull requests that does not require QA validation sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants