Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Metallic Slider #2032

Merged
merged 3 commits into from
Sep 12, 2024
Merged

fix: Metallic Slider #2032

merged 3 commits into from
Sep 12, 2024

Conversation

GBirch33
Copy link
Collaborator

@GBirch33 GBirch33 commented Sep 12, 2024

fix: #2031

Currently rocks at /goto sitio look like this: (metallic in look)
image
this change should fix that to look like this:
image

Summary by CodeRabbit

  • New Features

    • Updated asset bundle with new contents, possibly adding or modifying existing assets.
    • Upgraded the unity-shared-dependencies module to a newer version, potentially enhancing functionality and performance.
  • Bug Fixes

    • Adjusted metadata for asset bundles to reflect updated versioning and size.

Copy link

coderabbitai bot commented Sep 12, 2024

Walkthrough

The pull request includes modifications to an asset bundle file and an update to a subproject reference. The asset bundle located in Explorer/Assets/StreamingAssets/AssetBundles/dcl/scene_ignore_windows has updated its SHA-256 hash and size, indicating changes to its contents. Additionally, the unity-shared-dependencies module has been updated to a new commit reference, suggesting potential improvements or fixes.

Changes

File Path Change Summary
Explorer/Assets/StreamingAssets/AssetBundles/dcl/... Updated SHA-256 hash from d43219bdcf1ab067... to 367c0808fb929c6a... and size from 3754752 to 3763952 bytes.
Explorer/Assets/git-submodules/unity-shared-dependencies Updated subproject commit reference from 5cddda4cac3558d9... to 1d3755347ab9cdc3....

Assessment against linked issues

Objective Addressed Explanation
Rocks should not appear metallic (#[2031]) The PR does not address visual changes to rocks.

Possibly related PRs

Poem

In the bundle, a change so bright,
A hash updated, a new delight.
With dependencies fresh and new,
Our assets shine, a vibrant view!
Hopping along, we cheer with glee,
For every change brings joy, you see! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Sep 12, 2024

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 02432cd
Logs https://github.com/decentraland/unity-explorer/actions/runs/10830545273
Download Windows https://github.com/decentraland/unity-explorer/suites/28304807176/artifacts/1924721647
Download Mac https://github.com/decentraland/unity-explorer/suites/28304807176/artifacts/1924718141
Built on 2024-09-12T12:52:20Z

@m3taphysics m3taphysics changed the title Metallic Slider Fix fix: Metallic Slider Fix Sep 12, 2024
@m3taphysics m3taphysics changed the title fix: Metallic Slider Fix fix: Metallic Slider Sep 12, 2024
# Conflicts:
#	Explorer/Assets/git-submodules/unity-shared-dependencies
Copy link
Collaborator

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix implemented properly

metallicslider.mp4

@m3taphysics m3taphysics merged commit c2a1da3 into main Sep 12, 2024
5 checks passed
@m3taphysics m3taphysics deleted the fix/MetallicSliderFix branch September 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Rocks are too metallic
3 participants