fix: Badge Notification Flashing After Loading Screen

[sandrade-dcl]

What does this PR change?

Fix #2011

How to test the changes?

1. Launch the explorer and log in.
2. Wait for the loading screen to complete and spawn in Genesis Plaza.
3. Check that the badge notification doesn't appear at the beginning.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Summary by CodeRabbit

• New Features

  • Introduced a new animation state for badge notifications, enhancing animation flow.
  • Enhanced animation capabilities with new serialized fields for more nuanced control over animations.

• Bug Fixes

  • Adjusted the alpha property of the notification panel, potentially improving visibility and user experience.

• Documentation

  • Updated animation parameters and properties to reflect the latest changes in the animation system.

[github-actions]

New build in progress, come back later!

[coderabbitai]

Walkthrough

The pull request introduces modifications to the animation system within the Explorer application. Key changes include the addition of a new state in the BadgeNotificationController.controller, enhancements to the BadgeNotificationHide.anim file for more detailed animation control, and an adjustment to the alpha value of the NewNotificationPanel.prefab to potentially alter its visibility. These changes aim to improve the management and representation of animations related to badge notifications.

Changes

File Path	Change Summary
Explorer/Assets/DCL/Notifications/Animations/BadgeNotificationController.controller	Added a new state in the animator with updated default state reference.
Explorer/Assets/DCL/Notifications/Animations/BadgeNotificationHide.anim	Enhanced animation clip structure with new serialized fields for curves and properties.
Explorer/Assets/DCL/Notifications/NewNotification/Assets/NewNotificationPanel.prefab	Modified m_Alpha property from 1 to 0, affecting the visibility of the notification panel.

Assessment against linked issues

Objective	Addressed	Explanation
No badge notification should appear if there are no pending badges to claim (#2011)	❓	The changes do not explicitly confirm resolution of the flashing issue.

🐇 In the meadow where bunnies play,
New animations brighten the day.
With badges that dance and panels that hide,
A smoother experience, we take in our stride!
Hops of joy for changes so bright,
In the Explorer, all feels just right! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cfb65d7 and 4726ee1.

Files selected for processing (3)

• Explorer/Assets/DCL/Notifications/Animations/BadgeNotificationController.controller (3 hunks)
• Explorer/Assets/DCL/Notifications/Animations/BadgeNotificationHide.anim (3 hunks)
• Explorer/Assets/DCL/Notifications/NewNotification/Assets/NewNotificationPanel.prefab (1 hunks)

Additional comments not posted (4)

Explorer/Assets/DCL/Notifications/Animations/BadgeNotificationController.controller (2)

102-104: LGTM!

The addition of the InitialState aligns with the PR objective of ensuring that the badge notification does not appear at the beginning of the user experience. The positioning of the state at {x: 30, y: 10, z: 0} is also appropriate for the starting state.

---

116-116: LGTM!

Updating the m_DefaultState to reference the newly added InitialState is crucial for ensuring that the animation starts from the desired initial state. This change complements the addition of the InitialState and is necessary to prevent the brief flashing of the badge notification at the beginning of the user experience.

Explorer/Assets/DCL/Notifications/NewNotification/Assets/NewNotificationPanel.prefab (1)

269-269: Approved: m_Alpha change hides the notification panel

Setting m_Alpha to 0 will make the notification panel fully transparent, effectively hiding it from view. This aligns with the PR objective of ensuring the badge notification is not visible at the start.

However, please verify that:

1. The notification panel's visibility is properly toggled back on at the appropriate time through animations or scripting.
2. This change does not adversely affect any other notification functionality.

Explorer/Assets/DCL/Notifications/Animations/BadgeNotificationHide.anim (1)

Line range hint 1-1600: Animation system enhancements look good!

The changes to the AnimationClip structure, including the addition of detailed curve attributes and serialized properties, enhance the animation system's capabilities. These modifications allow for more nuanced control over animation behavior, particularly regarding alpha attributes and rotation orders.

The updates to path, classID, and flags also contribute to a more complex and flexible animation setup.

Overall, these changes improve the animation system, enabling more detailed and customizable animations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[RominaMarchetti]

Issue solved. The notification is not visible anymore.

Screen.Recording.2024-09-11.at.09.15.40.mov

[Ludmilafantaniella]

🟢 Fix verified on Windows. Approved by QA.

Untitled.video.-.Made.with.Clipchamp.mp4