Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: emotes tech debt #1894

Merged
merged 98 commits into from
Sep 10, 2024
Merged

chore: emotes tech debt #1894

merged 98 commits into from
Sep 10, 2024

Conversation

NickKhalow
Copy link
Collaborator

@NickKhalow NickKhalow commented Aug 27, 2024

What does this PR change?

Added updates from #1124 ticket

How to test the changes?

  1. Launch the explorer
  2. Play happy path, ensure that wearables and emotes work fine

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link
Collaborator

@mikhail-dcl mikhail-dcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now it looks much cleaner and organized!

# Conflicts:
#	Explorer/Assets/DCL/PerformanceAndDiagnostics/Analytics/DCL.Analytics.asmdef
#	Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef
#	Explorer/Assets/DCL/PluginSystem/Global/AvatarPlugin.cs
#	Explorer/Assets/DCL/PluginSystem/Global/EmotePlugin.cs
#	Explorer/Assets/DCL/Tests/Editor/DCL.EditMode.Tests.asmdef
#	Explorer/Assets/Scripts/CrdtEcsBridge/RestrictedActions/GlobalWorldActions.cs
#	Explorer/Assets/Scripts/CrdtEcsBridge/RestrictedActions/RestrictedActionsImplementation.asmdef
#	Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Reviewed by QA

@NickKhalow NickKhalow enabled auto-merge (squash) September 6, 2024 11:56
@NickKhalow NickKhalow merged commit b849464 into main Sep 10, 2024
4 of 5 checks passed
@NickKhalow NickKhalow deleted the chore/emotes-tech-debt branch September 10, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants