Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: spdm: improve GET_CAPABILITIES conformance #1

Closed

Conversation

twilfredo
Copy link

SPDM specification version 1.3 specifies that for a GET_CAPABILITIES
request, the DataTransferSize should equal MaxSPDMmsgSize, when
chunking is not used/supported.

This is not specified in the 1.2 specification currently, but a
clarification is to be added to specification 1.2.2 [1]. This patch
adds conformance to this clarification.

[1] DMTF/libspdm#2329 (comment)

SPDM specification version 1.3 specifies that for a `GET_CAPABILITIES`
request that the `DataTransferSize` should equal `MaxSPDMmsgSize`, when
chunking is not supported.

This is not specified in the 1.2 specification currently, but a
clarification is to be added to specification 1.2.2 [1]. This patch
adds conformance to this clarification.

[1] DMTF/libspdm#2329 (comment)

Signed-off-by: Wilfred Mallawa <[email protected]>
@l1k
Copy link

l1k commented Aug 31, 2023

Thank you @twilfredo, your testing and validation efforts of the in-kernel SPDM implementation are greatly appreciated.

I've amended my development branch to unconditionally set MaxSPDMmsgSize to the same value as DataTransferSize and I've added another commit at the tip of the branch which reverts MaxSPDMmsgSize to UINT_MAX again. That commit can be amended in the future with large SPDM message support.

@twilfredo
Copy link
Author

Thank you @twilfredo, your testing and validation efforts of the in-kernel SPDM implementation are greatly appreciated.

I've amended my development branch to unconditionally set MaxSPDMmsgSize to the same value as DataTransferSize and I've added another commit at the tip of the branch which reverts MaxSPDMmsgSize to UINT_MAX again. That commit can be amended in the future with large SPDM message support.

Okay sounds good then! cheers

@twilfredo twilfredo closed this by deleting the head repository Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants