Add quality factor to octet-stream mediatype #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this with Slim for a month or so using |
pieper
requested changes
Apr 26, 2023
| @@ -860,6 +860,11 @@ class DICOMwebClient { | |||
| DICOMwebClient._assertMediaTypeIsValid(mediaType); | |||
| let fieldValue = `multipart/related; type="${mediaType}"`; | |||
|
|
|||
| if (mediaType.endsWith("octet-stream")) { | |||
| // Prefer explicit transfer syntax | |||
| fieldValue += "; q=0.9"; | |||
There was a problem hiding this comment.
Is this going to work in general? It looks somehow jpeg specific. Also, shouldn't it be something configurable by the user rather than hard-coded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the IMS implementation, they may return
octet-streamwhenimage/jpegis available becauseoctet-streamappears higher on the list of acceptable media types. This PR addsq=0.9to the field value.Fixes #80