Update client.py #7
Conversation
|
Hey @ntua-el20184 it seems that you are using the ChatGPT for random code generation. Please don't do it in our repos. |
|
@manonthegithub this PR is related to #6, @ntua-el20184 forgot to mention it here but he wrote it in the issue |
|
@JJ-Author I now that. Please read the comment, it is not because the PR is not linked to an Issue |
|
I agree that tests would be good, but I wanted to test it myself first. did you? also @ntua-el20184 should have the chance to reply to our question and revise his PR. just closing a PR without any chance to do so seems not a polite way, especially since it is my issue and I started reviewing the PR |
|
@JJ-Author I did the review, it is not from nothing, my comment. I wrote above what is wrong and below you can see more details. |
| for url in urls: | ||
| __download_file__(url=url, filename=os.path.join(local_dir, wsha256(url))) | ||
|
|
||
| def download( |
There was a problem hiding this comment.
the function overrides the download below in the code, it is not editing of the old function function, but writing a new one in the same file with the old one on line 461 in old version
| # Changes made to fix the issue: | ||
| # 1. __get_content_variants function now correctly extracts content variants from the distribution string. | ||
| # 2. __get_extensions function now properly infers file format and compression from the URL path. |
There was a problem hiding this comment.
get_extension function is not changed, create_dataset function is not changed, get_content_variants function is not changed
|
@ntua-el20184 prepped a commit for you to open another PR |
| @@ -25,6 +28,94 @@ class DeployLogLevel(Enum): | |||
| info = 1 | |||
| debug = 2 | |||
|
|
|||
| # Define constants for different identifiers | |||
| GROUP_IDENTIFIER = "group" | |||
There was a problem hiding this comment.
hey thanks for your interest and contribution. will have a deeper look later. but quick question - what are those? the type can actually already be determined by the Databus-identifier/URI see e.g. https://dbpedia.gitbook.io/databus/model/uridesign
No description provided.