Fixup CI #1154
Merged
Fixup CI #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Otherwise it will complain about a syntax error. Signed-off-by: Alfred Wingate <[email protected]>
Signed-off-by: Alfred Wingate <[email protected]>
* 18.04 non extended support ended ten months ago. Signed-off-by: Alfred Wingate <[email protected]>
""" Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-python@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. """ Signed-off-by: Alfred Wingate <[email protected]>
* Setuptools isn't included in python 3.12 by default Signed-off-by: Alfred Wingate <[email protected]>
|
The os matrix could be removed as well and just use some singular Ubuntu LTS version for the runner. A future task would be to move to PEP517 and stop using setup.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes CI so that it runs and passes.
See #1153
Checklist
changelog.md.AUTHORSfile (or it's already there).