Use sqlite3 API to cancel running queries #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage ? 62.09%
=======================================
Files ? 23
Lines ? 2018
Branches ? 0
=======================================
Hits ? 1253
Misses ? 765
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mjpieters
force-pushed
the
keyboard_interrupt
branch
from
95edea6
to
1907e44
Compare
mjpieters
force-pushed
the
keyboard_interrupt
branch
from
1907e44
to
f9a1d43
Compare
Since the interrupt handler was the only code that referenced `sqlexecute.connection_id`, and the connection ids is merely a random UUID without any meaning, the code generating that UUID can be removed as well.
mjpieters
force-pushed
the
keyboard_interrupt
branch
from
f9a1d43
to
cc9689a
Compare
|
Rebased now that #167 has been merged. |
|
Looks good! Thank you! 🍨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #164.
Since the interrupt handler was the only code that referenced
sqlexecute.connection_id, and the connection ids is merely a randomUUID without any meaning, the code generating that UUID can be removed
as well.