Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ally): changing elements order #3337

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor(ally): changing elements order #3337

wants to merge 5 commits into from
+21 −21

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Oct 18, 2024 •
edited
Loading

Proposed changes

Screenreader users need related content to be after buttons and not before (might be okay due to the usage of the dialog role).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke
refactor: buttons shouldn't open content before them
f3ddd42 
SR users need related content to be after buttons and not before (might be ok due to dialog role)
@mfranzke
refactor: buttons shouldn't open content before them
89e6ac0 
SR users need related content to be after buttons and not before (might be ok due to dialog role)
@mfranzke
test: updated screenshots
bdc17d5
@mfranzke mfranzke added 🍄🆙improvement New feature or request 👂accessibility Accessibility issues/improvements labels Oct 18, 2024
@mfranzke mfranzke added this to the v0.5.0 milestone Oct 18, 2024
@mfranzke mfranzke self-assigned this Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-changing-elements-order

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Oct 18, 2024
@mfranzke mfranzke enabled auto-merge (squash) October 18, 2024 09:38
@mfranzke mfranzke removed their assignment Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
👂accessibility Accessibility issues/improvements 🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mfranzke